Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mass is not conserved for reflecting boundary conditions - Sod tube problem #78

Open
mugalino opened this issue Jul 28, 2023 · 1 comment

Comments

@mugalino
Copy link

Hello! We are currently doing some tests with Parthenon in another code in development and thought to test AthenaPK as well if the problem occurs there. It seems that both mass and energy is not conserved for a Sod tube problem with periodic boundary conditions along x2 and x3, and reflecting along the x1 direction. We also encounter this problem for an RT test we wrote for a private code we have where we set reflecting boundary conditions along the x1 direction as well.

We compile the code using these commands
cmake -DKokkos_ENABLE_OPENMP=off -DKokkos_ARCH_BDW=on ..
and
make -j

and run the Sod tube problem with the parameter file attached. Is there a fix for this problem or is it an unresolved issue for Parthenon? I run with commit 540deb9 in the main branch.

Parameter file used
sod.txt

Run with ix1_bc and ox1_bc set to periodic
parthenon_periodic.txt

Run with ix1_bc and ox1_bc set to reflecting
parthenon_reflecting.txt

Any insight about this would be really helpful!

@BenWibking
Copy link
Contributor

There is a partial fix in this work-in-progress PR: #58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants