Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Upgrade apollo-upload-client from 17.0.0 to 18.0.1 #9031

Open
wants to merge 5 commits into
base: alpha
Choose a base branch
from

Conversation

Moumouls
Copy link
Member

@Moumouls Moumouls commented Mar 17, 2024

Pull Request

Issue

Closes: #9009

Approach

Tasks

  • Add tests
  • Add changes to documentation (guides, repository pages, code comments)
  • Add security check
  • Add new Parse Error codes to Parse JS SDK

Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title feat: upgrade apollo upload client feat: Upgrade apollo upload client Mar 17, 2024
Copy link

parse-github-assistant bot commented Mar 17, 2024

Thanks for opening this pull request!

Copy link

codecov bot commented Mar 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.77%. Comparing base (da368ea) to head (84d64d6).

Additional details and impacted files
@@           Coverage Diff           @@
##            alpha    #9031   +/-   ##
=======================================
  Coverage   93.76%   93.77%           
=======================================
  Files         186      186           
  Lines       14679    14679           
=======================================
+ Hits        13764    13765    +1     
+ Misses        915      914    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtrezza mtrezza changed the title feat: Upgrade apollo upload client refactor: Bump apollo-upload-client from 17.0.0 to 18.0.1 Mar 19, 2024
@mtrezza mtrezza changed the title refactor: Bump apollo-upload-client from 17.0.0 to 18.0.1 refactor: Upgrade apollo-upload-client from 17.0.0 to 18.0.1 Mar 19, 2024
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mtrezza
Copy link
Member

mtrezza commented Mar 20, 2024

This requires at least Node 18.15, which is higher than the current min node engine version. We'll merge this in Parse Server 8 around Dec 2024.

@mtrezza mtrezza added block:major Needs to be resolved before next major release; remove label afterwards state:breaking Breaking change requires major version increment and `BREAKING CHANGE` commit message labels Mar 20, 2024
Copy link

The label block:major cannot be used here.

@parse-github-assistant parse-github-assistant bot removed the block:major Needs to be resolved before next major release; remove label afterwards label Mar 20, 2024
@mtrezza mtrezza added block:major Needs to be resolved before next major release; remove label afterwards and removed state:breaking Breaking change requires major version increment and `BREAKING CHANGE` commit message labels Mar 20, 2024
Copy link

The label block:major cannot be used here.

@parse-github-assistant parse-github-assistant bot removed the block:major Needs to be resolved before next major release; remove label afterwards label Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants