test: Failing test case for constraint notEqualTo null #8835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will reformat the title to use the proper commit message syntax. |
parse-github-assistant
bot
changed the title
Thanks for opening this pull request!
|
mtrezza
requested changes
Dec 16, 2023
mtrezza
requested changes
Dec 16, 2023
Actually, the server itself crashes since we are not handling the error thrown inside |
RahulLanjewar93
force-pushed
the
test-live-query-failing-for-notEqualTo-null
branch
from
e8137a6
to
cced89c
Compare
mtrezza
requested changes
Dec 16, 2023
RahulLanjewar93
changed the title
|
I will reformat the title to use the proper commit message syntax. |
parse-github-assistant
bot
changed the title
mtrezza
reviewed
Dec 16, 2023
mtrezza
reviewed
Dec 16, 2023
mtrezza
reviewed
Dec 16, 2023
Signed-off-by: Manuel <5673677+mtrezza@users.noreply.github.com>
Signed-off-by: Manuel <5673677+mtrezza@users.noreply.github.com>
Signed-off-by: Manuel <5673677+mtrezza@users.noreply.github.com>
mtrezza
reviewed
Dec 16, 2023
Signed-off-by: Manuel <5673677+mtrezza@users.noreply.github.com>
mtrezza
reviewed
Dec 16, 2023
Signed-off-by: Manuel <5673677+mtrezza@users.noreply.github.com>
mtrezza
reviewed
Dec 16, 2023
Signed-off-by: Manuel <5673677+mtrezza@users.noreply.github.com>
mtrezza
reviewed
Dec 16, 2023
Signed-off-by: Manuel <5673677+mtrezza@users.noreply.github.com>
|
I believe the test looks good now; do you have any suggestion for a fix? |
parse-server/src/LiveQuery/QueryTools.js Line 226 in 2c2563e this line should have optional chaining in my opinion |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
failing Test case for issue #8834
adding this so pr is not closed. closes #8834