New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Add test for incrementing number atomically #8789
base: alpha
Are you sure you want to change the base?
Conversation
Thanks for opening this pull request! |
I will reformat the title to use the proper commit message syntax. |
Signed-off-by: Theodor Lundqvist <31588188+theolundqvist@users.noreply.github.com>
Signed-off-by: Manuel <5673677+mtrezza@users.noreply.github.com>
Signed-off-by: Manuel <5673677+mtrezza@users.noreply.github.com>
Signed-off-by: Manuel <5673677+mtrezza@users.noreply.github.com>
Signed-off-by: Manuel <5673677+mtrezza@users.noreply.github.com>
Signed-off-by: Manuel <5673677+mtrezza@users.noreply.github.com>
Signed-off-by: Manuel <5673677+mtrezza@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## alpha #8789 +/- ##
=======================================
Coverage 94.14% 94.15%
=======================================
Files 186 186
Lines 14687 14687
=======================================
+ Hits 13827 13828 +1
+ Misses 860 859 -1 ☔ View full report in Codecov by Sentry. |
@theolundqvist the tests have passed; does that mean that there is no issue with atomically incrementing? |
@mtrezza I'm not so sure about that, I believe they passed when I created them. But I still had trouble with it. I am not invested in the parse platform anymore so do not have time to run further experiments. |
Pull Request
Issue
Closes: #8772 (cloud increment atomicity not working)
Approach
There does not seem to be a test that tests proper atomicity. This should be granted by mongo but here we are anyways.
Tasks