Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: GridFS file storage doesn't work with certain enableSchemaHooks settings #8773

Open
wants to merge 1 commit into
base: release-5.x.x
Choose a base branch
from

Conversation

tomwilsond1
Copy link

Pull Request

Issue

#8353

Closes: 8353

Approach

Remove enableSchemaHooks option before passing database options into GridFSBucketAdapter

Tasks

  • [x ] Add tests - tests updated
  • Add changes to documentation (guides, repository pages, code comments)
  • Add security check
  • Add new Parse Error codes to Parse JS SDK

@parse-github-assistant
Copy link

Thanks for opening this pull request!

@tomwilsond1 tomwilsond1 changed the title bugfix: delete enableSchemaHooks as an option before passing database options into file adapter fix: delete enableSchemaHooks as an option before passing database options into file adapter Oct 10, 2023
@parse-github-assistant
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title fix: delete enableSchemaHooks as an option before passing database options into file adapter fix: Delete enableSchemaHooks as an option before passing database options into file adapter Oct 10, 2023
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (0bb63d8) 94.11% compared to head (bc51681) 93.64%.

❗ Current head bc51681 differs from pull request most recent head bf1c93b. Consider uploading reports for the commit bf1c93b to get more accurate results

Additional details and impacted files
@@                Coverage Diff                @@
##           release-5.x.x    #8773      +/-   ##
=================================================
- Coverage          94.11%   93.64%   -0.47%     
=================================================
  Files                184      184              
  Lines              13809    13811       +2     
=================================================
- Hits               12996    12933      -63     
- Misses               813      878      +65     
Files Coverage Δ
src/Controllers/index.js 97.80% <100.00%> (+0.04%) ⬆️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtrezza
Copy link
Member

mtrezza commented Oct 10, 2023

@tomwilsond1 The PR needs to be an exact backport of #8467 to get it merged. The code can be modified, only if the code cannot be backported as is, due to code deviations between the alpha and release-5.x.x branches. I've renamed the PR to be consistent with the original PR.

@mtrezza mtrezza changed the title fix: Delete enableSchemaHooks as an option before passing database options into file adapter fix: GridFS file storage doesn't work with certain enableSchemaHooks settings Oct 10, 2023
@mtrezza
Copy link
Member

mtrezza commented Oct 18, 2023

@tomwilsond1 Would you want to make the few changes in this PR so we can get it merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants