feat: Switch from Yoga v2 to Apollo Server v4 #8727

Moumouls · 2023-08-31T00:23:23Z

Pull Request

Report security issues confidentially.
Any contribution is under this license.
Link this pull request to an issue.

Issue

Closes: #8728

Approach

Install graphql upload to support upload
Install GraphIQL from Yoga team since GraphIQL is standard, and the yoga team graphiql is fine
Take advantage of X-Parse-Application-Id as CSRF protection https://www.apollographql.com/docs/router/configuration/csrf/
apollo/server is more focused on NodeJS and have dedicated expressHandler, i hope it will be more stable in complex envs.
Now we have end to end stream system from client to bucket/storage system through GQL Upload API
Disable the cache control since it's not used at the moment and can slightly help for performance
Remove all it_only_node < 17, now upload works on major NodeJS version without issues
Added mime type package to auto add extension to filename without extension since it's the current behavior, without this we will have a breaking change

Performance tests:

Checked performance on ParseServerGraphQL test suite and complete test suite in my company with a lot of graphql requests, performance are close and quite the same.

Tasks

Add tests
Add changes to documentation (guides, repository pages, code comments)
Add security check
Add new Parse Error codes to Parse JS SDK

parse-github-assistant · 2023-08-31T00:23:25Z

I will reformat the title to use the proper commit message syntax.

parse-github-assistant · 2023-08-31T00:23:28Z

Thanks for opening this pull request!

codecov · 2023-08-31T00:31:08Z

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (80b987d) 94.29% compared to head (7882801) 94.32%.

❗ Current head 7882801 differs from pull request most recent head c9fc40a. Consider uploading reports for the commit c9fc40a to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##            alpha    #8727      +/-   ##
==========================================
+ Coverage   94.29%   94.32%   +0.02%     
==========================================
  Files         186      186              
  Lines       14785    14809      +24     
==========================================
+ Hits        13941    13968      +27     
+ Misses        844      841       -3

Files	Coverage Δ
src/GraphQL/ParseGraphQLServer.js	`94.73% <100.00%> (+0.85%)`	⬆️
src/GraphQL/loaders/defaultGraphQLTypes.js	`97.78% <100.00%> (-0.01%)`	⬇️
src/GraphQL/parseGraphQLUtils.js	`92.00% <100.00%> (ø)`
src/GraphQL/loaders/filesMutations.js	`89.58% <88.88%> (+8.93%)`	⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mtrezza · 2023-08-31T00:33:47Z

I notice that this also requires Node 16, so we'll wait with merging info alpha until Nov.

mtrezza

Apart from the requirement of Node >= 16, does this have any breaking changes? It's fine if it does, since we can only release it with Parse Server 7 (2024) anyway.

Moumouls · 2023-08-31T01:50:09Z

@mtrezza no breaking changen may be the error message of graphql upload, but developers should not rely on message.

Also i added mime type detection, since it's currently supported.

Yes @mtrezza it's not a problem to keep this PR for 2024 :)

mtrezza · 2023-09-01T23:39:19Z

package.json

@@ -48,6 +48,7 @@
    "lodash": "4.17.21",
    "lru-cache": "9.1.1",
    "mime": "3.0.0",
+    "mime-types": "2.1.35",


We already have mime, it seems that it's similar to mime-types. I think if possible we should decide for one of the two if they provide the same functionality.

mtrezza · 2023-09-01T23:43:51Z

Could you suggest an entry for the changelog?

The current title would only be a refactor, but from the PR comment it seems to include many more improvements, so it would be good to add them to the changelog. You don't have to write that into the PR title, I'll add the long version in the commit message and we keep the PR title short.

parse-github-assistant · 2023-09-16T03:01:28Z

The label block:major cannot be used here.

mtrezza · 2023-09-16T11:04:57Z

@Moumouls While this PR is still "recent" and to prepare it for merging in Nov, do you think you could address the mime dependency issue? Otherwise I'm afraid this PR will go stale and not get merged for a long time if no-one picks it up.

Moumouls · 2023-09-16T12:02:06Z

Hi @mtrezza, we should definitely merge this one. It works really well.

What is the mime dep issue. How is it linked to this Pr ?

Just tell me when I need to refresh the branch, and I'll be happy to fix last details to get it merged !

mtrezza · 2023-09-16T14:42:09Z

See #8727 (comment).

Moumouls · 2023-09-18T06:10:06Z

Nice catch @mtrezza , I'll take a look

Signed-off-by: Antoine Cormouls <contact.antoine.cormouls@gmail.com>

Moumouls · 2023-10-29T11:15:55Z

Hi @mtrezza i replaced last yoga dep with the CDN version of Apollo Sandbox: https://www.apollographql.com/docs/graphos/explorer/sandbox

Also fixed your feedback to use current mime dep

My team use this branch in production since now 2 months everything works well.

src/GraphQL/ParseGraphQLServer.js

src/GraphQL/loaders/filesMutations.js

kekami · 2023-11-02T19:49:15Z

src/GraphQL/ParseGraphQLServer.js

+        // needed since we use graphql upload
+        requestHeaders: ['X-Parse-Application-Id'],
+      },
+      introspection: true,


Introspection should probably be disabled by default for security reasons. Perhaps a config variable.

Hi @kekami , you are right but it needs a dedicated PR, i created the FR: #8800

Co-authored-by: Manuel <5673677+mtrezza@users.noreply.github.com> Signed-off-by: Antoine Cormouls <contact.antoine.cormouls@gmail.com>

mtrezza · 2023-12-25T19:26:09Z

@Moumouls We have begun merging the breaking change PRs for Parse Server 7. Could you please resolve the conflict in this PR so we can merge it?

mtrezza · 2024-03-02T01:03:07Z

Closing via #8959

Moumouls added 2 commits August 30, 2023 19:31

feat: switch to apollo and stream file upload

4f68411

test: max file size

3355952

parse-github-assistant bot changed the title ~~feat: switch from Yoga v2 to Apollo Server v4~~ feat: Switch from Yoga v2 to Apollo Server v4 Aug 31, 2023

Moumouls requested a review from a team August 31, 2023 00:23

mtrezza reviewed Aug 31, 2023

View reviewed changes

feat: add auto extension

56b58f9

mtrezza requested changes Sep 1, 2023

View reviewed changes

Merge branch 'alpha' into moumouls/switch-to-apollo-and-file-stream

b44fa39

mtrezza added state:breaking Breaking change requires major version increment and `BREAKING CHANGE` commit message block:major Needs to be resolved before next major release; remove label afterwards labels Sep 16, 2023

parse-github-assistant bot removed the block:major Needs to be resolved before next major release; remove label afterwards label Sep 16, 2023

Merge branch 'alpha' into moumouls/switch-to-apollo-and-file-stream

4bba5c0

This was referenced Oct 29, 2023

refactor: Update graphql-yoga to 4.X.X #8718

Closed

fix: GraphIQL offline install #8153

Closed

Moumouls added 2 commits October 29, 2023 12:12

feat: fix node 18 and move to apollo sandbox

f9b35bb

Merge branch 'alpha' into moumouls/switch-to-apollo-and-file-stream

13b2034

Signed-off-by: Antoine Cormouls <contact.antoine.cormouls@gmail.com>

test: update node 18

12df37f

Moumouls requested a review from a team October 29, 2023 11:44

Moumouls requested a review from mtrezza October 29, 2023 11:44

mtrezza reviewed Oct 29, 2023

View reviewed changes

src/GraphQL/ParseGraphQLServer.js Show resolved Hide resolved

src/GraphQL/loaders/filesMutations.js Outdated Show resolved Hide resolved

kekami reviewed Nov 2, 2023

View reviewed changes

Update src/GraphQL/loaders/filesMutations.js

c9fc40a

Co-authored-by: Manuel <5673677+mtrezza@users.noreply.github.com> Signed-off-by: Antoine Cormouls <contact.antoine.cormouls@gmail.com>

onurhanife mentioned this pull request Jan 17, 2024

feat: Switch from Yoga v2 to Apollo V4 merge #8893

Closed

4 tasks

mtrezza mentioned this pull request Feb 26, 2024

refactor: Upgrade ldapjs from 2.3.3 to 3.0.7 #8947

Merged

onurhanife mentioned this pull request Feb 27, 2024

feat: Switch GraphQL server from Yoga v2 to Apollo v4 #8959

Merged

4 tasks

mtrezza closed this Mar 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Switch from Yoga v2 to Apollo Server v4 #8727

feat: Switch from Yoga v2 to Apollo Server v4 #8727

Moumouls commented Aug 31, 2023 •

edited

parse-github-assistant bot commented Aug 31, 2023

parse-github-assistant bot commented Aug 31, 2023 •

edited

codecov bot commented Aug 31, 2023 •

edited

mtrezza commented Aug 31, 2023

mtrezza left a comment

Moumouls commented Aug 31, 2023

mtrezza Sep 1, 2023 •

edited

mtrezza commented Sep 1, 2023

parse-github-assistant bot commented Sep 16, 2023

mtrezza commented Sep 16, 2023

Moumouls commented Sep 16, 2023

mtrezza commented Sep 16, 2023

Moumouls commented Sep 18, 2023

Moumouls commented Oct 29, 2023 •

edited

kekami Nov 2, 2023

Moumouls Nov 4, 2023

mtrezza commented Dec 25, 2023

mtrezza commented Mar 2, 2024

feat: Switch from Yoga v2 to Apollo Server v4 #8727

feat: Switch from Yoga v2 to Apollo Server v4 #8727

Conversation

Moumouls commented Aug 31, 2023 • edited

Pull Request

Issue

Approach

Tasks

parse-github-assistant bot commented Aug 31, 2023

parse-github-assistant bot commented Aug 31, 2023 • edited

Thanks for opening this pull request!

codecov bot commented Aug 31, 2023 • edited

Codecov Report

mtrezza commented Aug 31, 2023

mtrezza left a comment

Choose a reason for hiding this comment

Moumouls commented Aug 31, 2023

mtrezza Sep 1, 2023 • edited

Choose a reason for hiding this comment

mtrezza commented Sep 1, 2023

parse-github-assistant bot commented Sep 16, 2023

mtrezza commented Sep 16, 2023

Moumouls commented Sep 16, 2023

mtrezza commented Sep 16, 2023

Moumouls commented Sep 18, 2023

Moumouls commented Oct 29, 2023 • edited

kekami Nov 2, 2023

Choose a reason for hiding this comment

Moumouls Nov 4, 2023

Choose a reason for hiding this comment

mtrezza commented Dec 25, 2023

mtrezza commented Mar 2, 2024

Moumouls commented Aug 31, 2023 •

edited

parse-github-assistant bot commented Aug 31, 2023 •

edited

codecov bot commented Aug 31, 2023 •

edited

mtrezza Sep 1, 2023 •

edited

Moumouls commented Oct 29, 2023 •

edited