Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow creating of unique indexes #8671

Open
wants to merge 4 commits into
base: alpha
Choose a base branch
from

Conversation

dblythy
Copy link
Member

@dblythy dblythy commented Jun 27, 2023

Pull Request

Issue

It is not currently possible to create indexes with options (sparse, unique, etc)

Closes: #7289

Approach

Adds _options key to index creation that can be used to specify index options. This should be safe as keys prefixed with _ are not permitted to be created.

Tasks

  • Add tests

@parse-github-assistant
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title feat: allow creating of unique indexes feat: Allow creating of unique indexes Jun 27, 2023
@parse-github-assistant
Copy link

Thanks for opening this pull request!

@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.45%. Comparing base (9c85e63) to head (35591c4).

Additional details and impacted files
@@            Coverage Diff             @@
##            alpha    #8671      +/-   ##
==========================================
- Coverage   94.19%   85.45%   -8.75%     
==========================================
  Files         186      186              
  Lines       14797    14805       +8     
==========================================
- Hits        13938    12651    -1287     
- Misses        859     2154    +1295     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@badboy-tian
Copy link

need it very much !!!

@mtrezza
Copy link
Member

mtrezza commented Mar 23, 2024

Not sure what the state of this PR is, but if you would like to check it out and if necessary complete it, we'll be happy to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to create unique indexes
3 participants