feat: allow certificate validation errors to be caught instead of terminating #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the long delay on this one. I like the idea. I believe we should continue terminating in the case there is no valid certificates though. What do you think? |
mtrezza
changed the title
Thanks for opening this pull request!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came up in the context of pushd. If there are a lot of push notification destinations set up, all with their own certificates, it's not ideal for one expired certificate to cause a terminating failure.
This tiny change wraps the validation in a try/catch so a validation error is still logged, but execution can continue.
Joe