fix: Incorrect key events instead of event for Live Activity
#136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Activity push notification payload (parse-community#133)" This reverts commit a25c835.
Thanks for opening this pull request!
|
kurtguenther
changed the title
kurtguenther
changed the title
kurtguenther
changed the title
|
I will reformat the title to use the proper commit message syntax. |
parse-github-assistant
bot
changed the title
mtrezza
changed the title
dismissal-date; fix incorrect key events instead of event for Live Activity
|
This is 2 PRs (feature addition + bug fix) in 1. Could you please separate the dismissal date addition into a separate PR? Unless it's related to the bug fix of course. |
mtrezza
changed the title
dismissal-date; fix incorrect key events instead of event for Live Activityevents instead of event for Live Activity
|
@kurtguenther Do you think you could move the feature addition into a separate PR, so we can get this bug fix merged? It also seems that the feature tests are not passing in the CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing from here.
This reverts this PR from @dplewis.
Additionally it adds
dismissal-dateas a field to APS + tests.