feat: expand best practices #924
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtrezza
reviewed
Apr 14, 2023
Co-authored-by: Manuel <5673677+mtrezza@users.noreply.github.com>
Co-authored-by: Manuel <5673677+mtrezza@users.noreply.github.com>
Co-authored-by: Manuel <5673677+mtrezza@users.noreply.github.com>
|
Should we merge this? |
|
It's ready for merge if you are ok! |
mtrezza
reviewed
Jul 4, 2023
| ```js | ||
| Parse.Cloud.define('updateEmail', async (req) => { | ||
| req.user.set('email', req.params.email); | ||
| await req.user.save(null, { useMasterKey: true }); |
There was a problem hiding this comment.
Wouldn't it be best practice to avoid any operation using useMasterKey: true but instead give only the user write permission in the object ACL? This would mitigate the risk that through a developer mistake in code someone could execute operations because they are using the master key; instead any permission would be bound to the user's session token. Using useMasterKey: true should only be necessary if the object is locked even for the user with read/write limited to master key.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #811