Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Convert ParseObject to TypeScript #2128

Merged
merged 4 commits into from
May 16, 2024

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented May 15, 2024

Pull Request

Issue

The Type Check CI job is failing.

Approach

  • Convert ParseObject.js to TS
  • Fixing lint issues
  • Properly handle typing in all current TS files

I updated the Type Check CI Job

  1. Ensure the .d.ts files generate without errors
  2. Lint on those .d.ts files (will have errors until project is fully TS)
  3. Test .d.ts files to find compile errors (will have errors until project is fully TS)

Copy link

parse-github-assistant bot commented May 15, 2024

Thanks for opening this pull request!

  • ❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (72bc9ac) to head (5d95ef0).
Report is 28 commits behind head on alpha.

Additional details and impacted files
@@             Coverage Diff             @@
##            alpha     #2128      +/-   ##
===========================================
+ Coverage   99.98%   100.00%   +0.01%     
===========================================
  Files          61        64       +3     
  Lines        6185      6327     +142     
  Branches     1499      1508       +9     
===========================================
+ Hits         6184      6327     +143     
+ Misses          1         0       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dplewis dplewis requested a review from a team May 15, 2024 22:52
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@dplewis dplewis requested a review from mtrezza May 16, 2024 00:54
@mtrezza mtrezza merged commit 81b6944 into parse-community:alpha May 16, 2024
10 of 11 checks passed
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.1.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label May 16, 2024
@dplewis dplewis deleted the parse-object-ts branch May 16, 2024 13:22
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.1.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version state:released-beta Released as beta version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants