Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

RPC: Get block #564

Merged
merged 4 commits into from Aug 14, 2018
Merged

RPC: Get block #564

merged 4 commits into from Aug 14, 2018

Conversation

tomusdrw
Copy link
Contributor

Related: #562

@tomusdrw tomusdrw added A0-please_review Pull request needs code review. M6-rpcapi labels Aug 14, 2018
@tomusdrw tomusdrw changed the title Get block RPC. RPC: Get block Aug 14, 2018
@tomusdrw tomusdrw mentioned this pull request Aug 14, 2018
Closed
gavofyork
gavofyork previously approved these changes Aug 14, 2018
View reviewed changes
@gavofyork
Copy link
Member

build fails:

error[E0243]: wrong number of type arguments: expected 3, found 2
  --> substrate/rpc-servers/src/lib.rs:49:5
   |
49 |     C: apis::chain::ChainApi<Block::Hash, Block::Header, Metadata=Metadata>,
   |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected 3 type arguments
error: aborting due to previous error

@gavofyork gavofyork added A7-looksgoodtestsfail and removed A0-please_review Pull request needs code review. labels Aug 14, 2018
@gavofyork gavofyork merged commit 0b880e4 into master Aug 14, 2018
@gavofyork gavofyork deleted the td-getblock branch August 14, 2018 19:42
@jacogr jacogr mentioned this pull request Aug 15, 2018
Closed
gavofyork pushed a commit that referenced this pull request Aug 15, 2018
@tomusdrw @gavofyork
RPC: Get block (#564)
976f892 
* Get block RPC.

* Fix rpc-servers.
@jacogr jacogr mentioned this pull request Sep 7, 2018
Closed
liuchengxu added a commit to chainx-org/substrate that referenced this pull request Aug 23, 2021
@liuchengxu @alannotnerd
Fix pre_release.yml (paritytech#564) (paritytech#579)
d6f6624 
* Update wasm build step

* Update pre_release ci

* Minimize change

Co-authored-by: alannotnerd <alan1995wang@outlook.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gavofyork gavofyork gavofyork approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tomusdrw @gavofyork