Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

RPC: Pending Extrinsics #563

Merged
merged 6 commits into from Aug 14, 2018
Merged

RPC: Pending Extrinsics #563

merged 6 commits into from Aug 14, 2018

Conversation

tomusdrw
Copy link
Contributor

@tomusdrw tomusdrw commented Aug 14, 2018

Not sure about the namespace though, should it go to a separate one? Any ideas for the name? node maybe? @gavofyork, @jacogr ?

@tomusdrw tomusdrw added A0-please_review Pull request needs code review. M6-rpcapi labels Aug 14, 2018
@tomusdrw tomusdrw changed the title Expose pending extrinsics RPC: Pending Extrinsics Aug 14, 2018
@emielsebastiaan
Copy link

Hi @tomusdrw,

I believe this is the pull request for issue #562 , right? Thank you for picking this up. Much appreciated.

If I am not mistaken this PR is about exposing the Intrinsics for the txpool (i.e. transactions/intrinsics that have not yet been included on chain).

My initial idea for issue #562 was to get the expose those Intrisics (txs) that have been validated and included on chain. I guess this should be an additional PR then.

@tomusdrw
Copy link
Contributor Author

@emielvanderhoek it's not for #562, it's a separate one. I'm working on the chain_getBlocks now.

@emielsebastiaan
Copy link

@tomusdrw perfecto 💯 spoke too soon...

gavofyork
gavofyork previously approved these changes Aug 14, 2018
@gavofyork
Copy link
Member

author set of RPCs is the right way to go, i think.

@gavofyork
Copy link
Member

CI fails:

error[E0053]: method `should_replace` has an incompatible type for trait
   --> polkadot/transaction-pool/src/lib.rs:181:2
    |
181 |     fn should_replace(&self, old: &VerifiedTransaction, _new: &VerifiedTransaction) -> bool {
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected enum `extrinsic_pool::transaction_pool::scoring::Choice`, found bool
    |
    = note: expected type `fn(&Scoring, &VerifiedTransaction, &VerifiedTransaction) -> extrinsic_pool::transaction_pool::scoring::Choice`
               found type `fn(&Scoring, &VerifiedTransaction, &VerifiedTransaction) -> bool`

@gavofyork gavofyork added A7-looksgoodtestsfail and removed A0-please_review Pull request needs code review. labels Aug 14, 2018
@gavofyork gavofyork merged commit cdca329 into master Aug 14, 2018
@gavofyork gavofyork deleted the td-extrinsics branch August 14, 2018 16:51
gavofyork pushed a commit that referenced this pull request Sep 8, 2018
* Expose extrinsics in pool.

* Add test.

* Use latest transaction pool.

* Fix compilation.
lamafab pushed a commit to lamafab/substrate that referenced this pull request Jun 16, 2020
* Update to latest Substrate master (paritytech#570)

* Bump substrate/version (paritytech#557)

* Bump version and Substrate (paritytech#560)

* Bump version and Substrate

* Bump version and Substrate

* Bump versions

* bump substrate to release specific v0.6.15

* Update lock

* Prepare Polkadot update for Substrate runtime interface 2.0 (paritytech#563)

* Prepare Polkadot update for Substrate runtime interface 2.0

* bump substrate to release specific v0.6.15

* Switch to `polkadot-master`

* Version bump

* Master backports

* Bump runtime

* Fix tests

* Fix tests

* Another fix.
liuchengxu added a commit to chainx-org/substrate that referenced this pull request Aug 23, 2021
* Make slash for missed blocks configurable

* Build wasm and nits

* Set minimal_penalty to 0.01 PCX by default

* Build wasm

* Pass staking tests

* Remove unneeded impl

* Build wasm
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants