memcpy: implement #161
Closed
memcpy: implement #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement a basic memcpy, not much to say here. Signed-off-by: Morgan Gangwere <morgan.gangwere@gmail.com>
|
see #130 -> fixes? |
|
depends on #160 -> I use a static |
|
You're correct -- I made the (bad) assumption that |
Bad assertion logic would have caused a problem if `dst < src` in debug builds. This logic would have also caused a problem if the flag FAIL_FAST was defined at compile-time. This should probably be wrapped in a macro (or some such) that checks that the bounds are correct. Multiple asserts in the non fail-fast variant are cleaner, but may or may not be optimized out when gcc comes along and tries to run "basic" optimizations. Signed-off-by: Morgan Gangwere <morgan.gangwere@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a basic memcpy, not much to say here.
Signed-off-by: Morgan Gangwere morgan.gangwere@gmail.com