feat: proof verification #8220
Merged
feat: proof verification #8220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkrasiuk
requested review from
rakita,
joshieDo,
shekhirin and
gakonst
as code owners
gakonst
approved these changes
May 13, 2024
| /// Verify the proof against the provided storage root. | ||
| pub fn verify(&self, root: B256) -> Result<(), ProofVerificationError> { | ||
| let expected = | ||
| if self.value.is_zero() { None } else { Some(encode_fixed_size(&self.value).to_vec()) }; |
There was a problem hiding this comment.
Suggested change
| if self.value.is_zero() { None } else { Some(encode_fixed_size(&self.value).to_vec()) }; | |
| // If the storage `value` is Zero then it's no longer part of the trie | |
| if self.value.is_zero() { None } else { Some(encode_fixed_size(&self.value).to_vec()) }; |
this could also probably be self.value.encode() given U256: RlpEncodable seems like footgun
| address, | ||
| info: None, | ||
| proof: Vec::new(), | ||
| storage_root: EMPTY_ROOT_HASH, |
rkrasiuk
force-pushed
the
rkrasiuk/account-proof-verification
branch
from
c074975
to
2910d21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Integrate proof verification introduced in alloy-rs/trie#13. Closes #8175