Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: revert pngx pdf viewer to third party package #6741

Merged
merged 1 commit into from
May 16, 2024

Conversation

shamoon
Copy link
Member

@shamoon shamoon commented May 15, 2024

Proposed change

No rush here.

After a couple of PRs got merged the third party version of this seems to be alive again and back up-to-date with ours and theres really no reason to maintain ours anymore. Of course the 'risk' is that project goes dormant again and we are limited by that but:

  • pdfjs v4.x is a big upgrade and I have no intention of working on integrating that any time soon. Even if I did, I'd happily submit it to that package.
  • The current pdfjs 3.11.174 is presumably the last 3.x they'll release, so we shouldn't be limited by that by relying on the third party version.
  • The CVE fix is included.

As you can see there are really no substantive changes in this PR, which is great cause it makes me reasonably confident it wont break things (ugh, famous last words lately?).

Closes #(issue or discussion)

Type of change

  • Bug fix: non-breaking change which fixes an issue.
  • New feature / Enhancement: non-breaking change which adds functionality. Please read the important note above.
  • Breaking change: fix or feature that would cause existing functionality to not work as expected.
  • Documentation only.
  • Other. Please explain: chore

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have included testing coverage for new code in this PR, for backend and / or front-end changes.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@shamoon shamoon requested a review from a team as a code owner May 15, 2024 22:09
@paperless-ngx-secretary paperless-ngx-secretary bot added frontend non-trivial Requires approval by several team members labels May 15, 2024
@github-actions github-actions bot added the enhancement New feature label May 15, 2024
Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.19%. Comparing base (50a6181) to head (b0a23dc).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #6741   +/-   ##
=======================================
  Coverage   97.19%   97.19%           
=======================================
  Files         436      436           
  Lines       17977    17977           
  Branches     1527     1493   -34     
=======================================
  Hits        17473    17473           
  Misses        501      501           
  Partials        3        3           
Flag Coverage Δ
backend 95.88% <ø> (ø)
frontend 98.63% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shamoon shamoon enabled auto-merge (squash) May 15, 2024 22:10
@shamoon shamoon added dependencies Pull requests that update a dependency file and removed enhancement New feature labels May 16, 2024
@shamoon shamoon force-pushed the feature-readd-ng2-pdf-viewer branch from 248b864 to b0a23dc Compare May 16, 2024 05:19
Copy link
Member

@stumpylog stumpylog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to drop the manual version

@shamoon shamoon merged commit 019a255 into dev May 16, 2024
30 checks passed
@shamoon shamoon deleted the feature-readd-ng2-pdf-viewer branch May 16, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file frontend non-trivial Requires approval by several team members
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants