This repository has been archived by the owner on Jun 10, 2023. It is now read-only.
Add support for multiple submenus on desktop. #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuraaga
added a commit
to tetratelabs/wazero
that referenced
this pull request
May 13, 2022
anuraaga
added a commit
to tetratelabs/wazero
that referenced
this pull request
May 13, 2022
Signed-off-by: Anuraag Agrawal <anuraaga@gmail.com>
codefromthecrypt
added a commit
to tetratelabs/wazero
that referenced
this pull request
May 13, 2022
* Vendor in panr/hugo-theme-hello-friend#292 main.js Signed-off-by: Adrian Cole <adrian@tetrate.io> Signed-off-by: Anuraag Agrawal <anuraaga@gmail.com> Co-authored-by: Anuraag Agrawal <anuraaga@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks a lot for this easy to use theme! We're starting to use it for wazero
The desktop menu supports one submenu but no more. As the behavior of each submenu is mostly self-contained, we can support multiple by scoping lookups of the submenu component to each one after querying all of them. Hopefully this makes sense as a feature request.