Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to app4mc 2.0.0 #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jansbecker
Copy link

Migration to app4mc-2.0.0

@steghoja
Copy link
Collaborator

This looks good!

But I am wondering if this will work out-of-the-box since Capra still uses APP4MC 1.0.0 in its target definition. Do we need to add APP4MC 2.0 as an explicit dependency in the setup file? Or should we update Capra and use a newer version of it in the future?

@jansbecker
Copy link
Author

We have to switch to APP4MC 2.0.0 also in the dependency file. I forgot this. Capra shall work with APP4MC 2.0.0 as well. I will try to change the dependency and then add another commit to the pull request.

@jansbecker
Copy link
Author

The dependency to app4mc is part of a target definition, right? So far I didn't find a way to patch the choosen target definition from within the oomph setup script (I cannot find any documentation about the pde:TargetPlatformTask that seems responsible for this). I also doubt that this makes much sense. Maybe it would be better to modify the target definition in the CAPRA repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants