Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: fix CI failure for PDEP with status: Draft #58458

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Aloqeely
Copy link
Contributor

cc @WillAyd

This will only fix the CI failure, but 2 things to note:
1- The PDEP won't be shown in https://pandas.pydata.org/about/roadmap.html
2- If the PR gets the PDEP label, it will be considered as "Under Discussion" in the website roadmap
I want to fix that, but how will we differentiate? Do we check if the PR is marked as Draft? Or do we check if the PR has a certain label? (e.g. make a PDEP: draft label or use the needs discussion label)

@Aloqeely Aloqeely marked this pull request as draft April 27, 2024 17:19
@WillAyd
Copy link
Member

WillAyd commented Apr 27, 2024

I don't think we want to add draft PDEPs to the website but @datapythonista would know best

@Aloqeely Aloqeely marked this pull request as ready for review April 30, 2024 13:20
@Aloqeely
Copy link
Contributor Author

Aloqeely commented Apr 30, 2024

Going to mark this as ready for review as this fixes the CI failure.

As for the problem of draft PDEPs currently appearing in the website roadmap, the only fix I can think of is to make an API request for each opened PDEP PR and fetch the content of the PDEP file and see if the status is written as draft or not, but I will wait for @datapythonista's input before doing that as that is not the cleanest of solutions.

@WillAyd if you think it's appropriate, can we add some certain label to be able to differentiate between draft and under discussion PDEPs? If that's possible, then I can follow up with a very simple fix, otherwise I will just open an issue to not forget about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants