BUG: Ignore warning for duplicate columns in to_dict when orient='tight'
#58335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Abdulaziz Aloqeely <52792999+Aloqeely@users.noreply.github.com>
|
Thank you for replying so quickly, all the comments are fixed. |
mroeschke
reviewed
Apr 22, 2024
mroeschke
added
Output-Formatting
mroeschke
reviewed
Apr 23, 2024
| def test_to_dict_tight_no_warning_with_duplicate_column(self): | ||
| # GH#58281 | ||
| df = DataFrame([[1, 2], [3, 4], [5, 6]], columns=["A", "A"]) | ||
| assert df.to_dict(orient="tight") == { |
There was a problem hiding this comment.
Can you still assert that df.to_dict(orient="tight") doesn't raise a warning?
Also can you structure like
result =
expected =
assert result == expected
There was a problem hiding this comment.
How about this time? Am I understanding correctly?
mroeschke
approved these changes
Apr 24, 2024
|
Thanks @luke396 |
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
…ight' (pandas-dev#58335) * Ignore warning for duplicate columns in to_dict when orient='tight' * Add whatsnew * Update doc/source/whatsnew/v3.0.0.rst Co-authored-by: Abdulaziz Aloqeely <52792999+Aloqeely@users.noreply.github.com> * Update whatsnew and redefine duplicate columns * Use assert instead * assert not raise and equal --------- Co-authored-by: Abdulaziz Aloqeely <52792999+Aloqeely@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.