Added the note of class DataFrame #44719
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
3 tasks
jreback
requested changes
Dec 2, 2021
| @@ -472,7 +472,9 @@ class DataFrame(NDFrame, OpsMixin): | |||
| data : ndarray (structured or homogeneous), Iterable, dict, or DataFrame | |||
| Dict can contain Series, arrays, constants, dataclass or list-like objects. If | |||
| data is a dict, column order follows insertion-order. If a dict contains Series | |||
| which have an index defined, it is aligned by its index. | |||
| which have an index defined, it is aligned by its index.For best performance, | |||
There was a problem hiding this comment.
well the problem here is an object that doesn't object the array protocol.
|
closing as won't fix. I don't find this a useful doc addition; discussed in the original issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the note of class DataFrame, if the data type is torch.Tensor when creating DataFrame, it should be converted to Numpy Array for better performance.
More More detailed description in #44616.
Originally, the judgment was added directly in the init method of DataFrame: whether data is torch.Tensor
if isinstance(data,torch.Tensor):
data = data.numpy()
This can solve the time-consuming problem of DataFrame (tensor), but need to import torch, which may affect other uses of pandas, so it is more appropriate to add an explanation in the class comment.