BUG: Allow cast from cat to extension dtype #28762
Conversation
|
Getting this Should |
|
Hmm have we ever considered making the @TomAugspurger any thoughts? Would certainly help the type system |
|
I thought it was an instance of abc.Sequence, but apparently not. Apparently, ndarray's aren't Sequences either... I don't have a strong opinion here. |
jschendel
added
Bug
Categorical
| @@ -520,6 +520,8 @@ def astype(self, dtype: Dtype, copy: bool = True) -> ArrayLike: | |||
| if dtype == self.dtype: | |||
| return self | |||
| return self._set_dtype(dtype) | |||
| if is_extension_array_dtype(dtype): | |||
| return array(self, dtype=dtype, copy=copy) # type: ignore # GH 28770 | |||
There was a problem hiding this comment.
maybe the following an elif
Also fix typo in test
| @@ -217,6 +217,7 @@ Categorical | |||
|
|
|||
| - Added test to assert the :func:`fillna` raises the correct ValueError message when the value isn't a value from categories (:issue:`13628`) | |||
| - Bug in :meth:`Categorical.astype` where ``NaN`` values were handled incorrectly when casting to int (:issue:`28406`) | |||
| - Bug in :meth:`Categorical.astype` not allowing for casting to extension dtypes (:issue:`28668`) | |||
There was a problem hiding this comment.
can you add another note about the merge issue (which was the OP); IIRC its the same issue number. otherwise lgtm, ping on green.
There was a problem hiding this comment.
@jreback Included a note for the merge issue, let me know if it looks good and thanks for the review
|
thanks @dsaxton |
black pandasModifies
categorical.astypeto allow for casting to extension dtypes. Also fixes the merge issue identified in #28668.