Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Check series names #10276

Merged
merged 1 commit into from Jun 5, 2015
Merged

TST: Check series names #10276

merged 1 commit into from Jun 5, 2015

Conversation

sinhrks
Copy link
Member

@sinhrks sinhrks commented Jun 4, 2015

Related to #9972. Made assert_series_equal to check name attribute.

@jreback jreback added the Testing pandas testing functions or related to the test suite label Jun 4, 2015
@jreback jreback added this to the 0.16.2 milestone Jun 4, 2015
@jreback
Copy link
Contributor

jreback commented Jun 5, 2015

lgtm. any things that we need to put to watch out for in the future? e.g. where you needed to do check_names=False but couldn't check the name?

@sinhrks
Copy link
Member Author

sinhrks commented Jun 5, 2015

As far as I know:

But we may find further when adding name attribute to all Series in test cases.

@jreback
Copy link
Contributor

jreback commented Jun 5, 2015

@sinhrks but you are testing this no? (e.g. you added it and fixed what was necessary)

@sinhrks
Copy link
Member Author

sinhrks commented Jun 5, 2015

Ah, I meant the name attributes of existing test cases are all tested. But I didn't change test cases which uses Series(..., name=None) yet, and adding explicit name may reveal further problem.

I'll continue to work on Index and Series metadata issues, hopefully change all test cases to have explicit name assignment like below (intends to be a fix for #10150):

@jreback
Copy link
Contributor

jreback commented Jun 5, 2015

ahh, I see. cool. ok let's merge this. thanks!

jreback added a commit that referenced this pull request Jun 5, 2015
@jreback jreback merged commit 22359aa into pandas-dev:master Jun 5, 2015
@sinhrks sinhrks deleted the series_name branch June 5, 2015 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants