Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

showbase: Annotate basic ShowBase setup/shutdown methods #1558

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

WMOkiishi
Copy link
Contributor

Change description

These changes add type annotations to some basic ShowBase methods used on setup and shutdown. This mostly comprises adding annotations to attributes assigned in ShowBase.__init__. See also #1217, which aimed to do mostly the same thing, but seems to have been abandoned.

Checklist

I have done my best to ensure that…

  • …I have familiarized myself with the CONTRIBUTING.md file
  • …this change follows the coding style and design patterns of the codebase
  • …I own the intellectual property rights to this code
  • …the intent of this change is clearly explained
  • …existing uses of the Panda3D API are not broken
  • …the changed code is adequately covered by the test suite, where possible.

direct/src/showbase/ShowBase.py Outdated Show resolved Hide resolved
direct/src/showbase/ShowBase.py Show resolved Hide resolved
direct/src/showbase/ShowBase.py Outdated Show resolved Hide resolved
@WMOkiishi
Copy link
Contributor Author

Alright, I think I've found a good way to make mypy not complain about setting custom attributes on builtins. Let me know if it's acceptable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants