fix: Rpc request increase #9611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
memoyil
requested review from
chef-jojo,
ChefMomota,
Chef-Yogi,
chefjackson,
ChefJerry and
ChefBingbong
as code owners
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
5 Ignored Deployments
|
memoyil
force-pushed
the
feature/fix_rpc_request_increase
branch
from
d9f108e
to
672e092
Compare
memoyil
force-pushed
the
feature/fix_rpc_request_increase
branch
from
672e092
to
21f2bfd
Compare
memoyil
force-pushed
the
feature/fix_rpc_request_increase
branch
from
21f2bfd
to
2028740
Compare
memoyil
force-pushed
the
feature/fix_rpc_request_increase
branch
from
2028740
to
f864d41
Compare
chefjackson
reviewed
Apr 16, 2024
| @@ -28,8 +30,9 @@ export const useTokenBalanceByChain = (tokenAddress: Address, chainIdOverride?: | |||
| }) | |||
|
|
|||
| useEffect(() => { | |||
| refetch() | |||
| }, [blockNumber, refetch]) | |||
| queryClient.invalidateQueries({ queryKey }) | |||
There was a problem hiding this comment.
After second thought, I'm a bit confused why refetch is changing more frequently. Shouldn't the reference to refetch changes whenever queryKey is updated? Plus react query should have its own hash function to serialize the queryKey
There was a problem hiding this comment.
issue happens when multiple hooks refetching the same query key, when invalidation used it will taken into account the deduplication
There was a problem hiding this comment.
and refetch also bypasses enabled property, so even if the enabled is false when refetch is called it will fetch the query
There was a problem hiding this comment.
Just realized useReadContract has this scopeKey option
https://wagmi.sh/react/api/hooks/useReadContract#scopekey
Can we simply add blockNumber to scopeKey? For example
const { data, status, queryKey, refetch, ...rest } = useReadContract({
chainId: chainIdOverride || chainId,
abi: erc20Abi,
address: tokenAddress,
functionName: 'balanceOf',
args: [account || '0x'],
query: {
enabled: !!account,
},
scopeKey: `useTokenBalanceByChain_${blockNumber}`,
})So there's no need for effect
There was a problem hiding this comment.
and with placeholderData we can keep the previous data visible
There was a problem hiding this comment.
@chefjackson Applied cancelRefetch: false to avoid deduplication
There was a problem hiding this comment.
@chefjackson When scopekey is used it will create a querykey like this
[ "readContract", { "chainId": 56, "address": "0xbb4CdB9CBd36B01bD1cBaEBF2De08d9173bc095c", "functionName": "balanceOf", "scopeKey": "useTokenBalanceByChain_37933594" } ]
So it doesn't affect query deduplication (wevm/wagmi#2031) and it is mainly used to refetch manually based on the scopekey (by using key filters instead of exact match)
memoyil
force-pushed
the
feature/fix_rpc_request_increase
branch
from
0116675
to
e1552ac
Compare
|
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
|
chefjackson
reviewed
Apr 17, 2024
|
|
||
| const { status, refetch, data } = useBalance({ | ||
| const { status, refetch, data, queryKey } = useBalance({ |
There was a problem hiding this comment.
do we still need queryKey here?
chefjackson
reviewed
Apr 17, 2024
| queryClient.invalidateQueries({ queryKey: readContractResult.queryKey }, { cancelRefetch: false }) | ||
| } | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps | ||
| }, [blockNumber, queryClient]) |
There was a problem hiding this comment.
watch should be one of the dependencies?
chefjackson
previously approved these changes
Apr 17, 2024
chefjackson
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR updates dependencies, adds new hooks, and refactors existing ones in the
wagmipackage.Detailed summary
package.jsonuseBalance.ts