Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No longer requires Click, as
click.style
wasn't doing what I expected and other utilities weren't much use. Replaced with a simple wrapper with just the styles used. On Windows, style information is only added if Colorama is installed. The handler added to the "werkzeug" logger wraps the stream withcolorama.AnsiToWin32
to output the styles correctly.This means that if the user overrides the logging configuration, they'll get ANSI codes in the output again. However, that was already the case, even before the switch from termcolor to Click. If they're overriding logging, they can also make the decision to call
colorama.init()
before that to ensuresys.stderr
is wrapped globally, but I didn't want Werkzeug to force that on import.Also considered just removing styles. Until the recent switch to Click very few people ever saw them because termcolor wouldn't have been installed. For now I'll leave them in.
Checklist:
CHANGES.rst
summarizing the change and linking to the issue... versionchanged::
entries in any relevant code docs.pre-commit
hooks and fix any issues.pytest
andtox
, no tests failed.