New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove jQuery #1835
Remove jQuery #1835
Conversation
Closes pallets#1807 Co-authored-by: Chris N <hello@chris-nguyen.me>
Stop using jQuery for creating the console icons and event listeners.
…p/werkzeug into 1807-remove-jquery
Removed Gist Debugger feature
…p/werkzeug into 1807-remove-jquery
Move createElement calls into their own functions, overall cleanup of openShell.
What's wrong with |
I agree, use Do in general look for old patterns though, we probably shouldn't use |
General code cleanup
…p/werkzeug into 1807-remove-jquery
Also address some code review comments
Ready for maintainer review. |
|
I would reformat it with prettier. Here's a decent config (but can be changed of course in case you prefer double quotes to be consistent with the Python style):
I'd also suggest running |
This comment has been minimized.
This comment has been minimized.
Couldn't push to this branch, so squashed and rebased in #1857. |
Closes #1807