Use partial(next, ...) instead get_next() #470
Conversation
| @@ -10,6 +10,7 @@ | |||
| """ | |||
| import os | |||
| import sys | |||
| from functools import reduce, partial | |||
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
LGTM |
|
Since I'm not a committer, and you seem to approve this change, mind merging it? (Same for my other PRs where you gave LGTM) |
|
I'm the least-experienced maintainer on the team, so if I review a PR and think it looks good but that there's a chance I might be unaware of why something is the way it is, I refrain from merging and just give a LGTM. So far that's worked pretty well, sometimes it gets merged directly by one of the other maintainers, sometimes someone chimes in with more background on why something is a particular way. But generally those PRs get a second look. BTW, I know many of these PRs/issues just sat for a while, but we're making consistent progress on the backlog now that we moved to |
|
Fine with me. I didn't meant to urge you. It just wondered why a maintainer gives LGTM, without merging the change or any further comment. Anyway, thanks for moving things forward here. |
|
I'm going to go ahead and merge this. |
Since jinja2 doesn't support any version older than Python 2.6 anymore, we can simply use the
nextbuilt-in function rather than abstractingit.__next__(Python 3) andit.next(Python 2) ourselves.