Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing missing closing </li> statements in the base layout of the flaskr tutorial #5482

Closed
wants to merge 2 commits into from

Conversation

gatoniel
Copy link

I did not create an issue for this.

In my opinion, the closing tags </li> were missing in the g.user auth part of the base.html template of the flaskr tutorial. I added them in two places:

  • docs/tutorial/templates.rst
  • examples/tutorial/flaskr/templates/base.html

So far I have not changed the CHANGES.rst, as I think this is a minor change.

@davidism davidism closed this May 11, 2024
@davidism
Copy link
Member

davidism commented May 11, 2024

li does not require a closing tag. Be sure to search first before working on something like this, there are many previous closed PRs discussing it.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants