Remove half-baked support for method calls #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bjornbm please let me know if this helps fix those issues you found. |
|
Hi @hugomg, I get sensible error messages now, failing early on method syntax (which I agree seems like the right approach). Regarding this error message (on line 639): Perhaps “method function” is redundant? I would propose: Or, maybe: |
|
Great idea! Let's go with the shortest version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current support for ":" syntax is well-intended but buggy (See #580 and #581). Let's get rid of it for now. When it comes the time to implement method calls for real, it should not be difficult to add this stuff back in.
Closes #581