Add a type-checking command line flag #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ps.: I still need to add tests before this can be merged. |
|
In reply to #277 (comment) I don't think this adds much for the purposes of #277 (comment). It is nice perhaps to not generate the .lua files, but they aren't/weren't causing much trouble either. For sure this is cleaner if one does not intend to run additional Lua tools over them. |
|
Actually, it does add significant value if the checking is more rigorous than that of |
Marking the Pallene code blocks as lua code provides better-than-nothing syntax highlighting on Github (and other tools). Obviously Pallene specifics (typealias, record, types…) do not get highlighted as keywords.
Mark Pallene code blocks as lua for highlighting
In manual, sum_list function has an extra do. If I’m not mistaken, this is an error in the documentation, because this example isn’t grammatically correct and doesn’t compile. This tweak fixes that
Manual: sum_list example: remove unnecessary “do”
Previously we used --stop-after, but we removed that... A flag to stop the compiler after the type-checking step might be useful for text editor and linter support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we used --stop-after, but we removed that... A flag to stop the compiler after the type-checking step might be useful for text editor and linter support.