Recompile benchmarks when running test suite #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because the test suite did not recompile the benchmarks, sometimes the tests would pass on the local machine but not pass on the CI server. The immediate workaround is to force recompilation when running the test suite. In the future it would be nice if we replaced the benchlib by something less crazy.
|
Hopefully this workaround should do for now. I opened #483 to remember to make a proper fix later. |
srijan-paul
approved these changes
Sep 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the test suite did not recompile the benchmarks, sometimes the tests would pass on the local machine but not pass on the CI server. The immediate workaround is to force recompilation when running the test suite. In the future it would be nice if we replaced the benchlib by something less crazy.