Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Define no-null-keyword rule #722

Merged
merged 1 commit into from Dec 5, 2015
Merged

Define no-null-keyword rule #722

merged 1 commit into from Dec 5, 2015

Conversation

myitcv
Copy link
Contributor

@myitcv myitcv commented Oct 9, 2015

Addresses #677

Comments/thoughts welcomed. I've duly referenced the TypeScript repo version on which this is shamelessly based.

"../typings/node.d.ts",
"../typings/typescriptServices.d.ts",
"../lib/tslint.d.ts",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a negative diff; I've simply sorted the contents.

@jkillian
Copy link
Contributor

Can you add this to sample.tslint.json and to the README?

@jkillian
Copy link
Contributor

Actually, before you do that, one area of discussion. We're not sure how to handle rules that conflict with each other (we accidentally ran into this problem about a week ago #711).

This rule would potentially conflict with: #625

@myitcv
Copy link
Contributor Author

myitcv commented Oct 17, 2015

@jkillian added to sample.tslint.json and README updated (rebased at the same time)

Yes, this might potentially conflict with #625 (and indeed others) but I think it's obvious why it would conflict. The problem arises where rules conflict and its not immediately obvious why.

@jkillian
Copy link
Contributor

Given more thought, I'm happy to merge this. I think the solution is to just check for conflicting rules as mentioned in #711. @adidahiya, good with you?

@myitcv
Copy link
Contributor Author

myitcv commented Oct 20, 2015

@jkillian just rebased this (saw your comment in #747)

@myitcv
Copy link
Contributor Author

myitcv commented Dec 1, 2015

@adidahiya @jkillian - just rebased this

@adidahiya
Copy link
Contributor

👍

adidahiya added a commit that referenced this pull request Dec 5, 2015
@adidahiya adidahiya merged commit c6dc9ca into palantir:master Dec 5, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants