This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
[new-rule-option] [no-implicit-dependencies] - add whitelist (#3839) #3979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your interest in palantir/tslint, @ajcrites! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
|
I believe this also covers #3483 |
This allows you to specify a whitelist of modules that will not be part of package.json such as project-relative aliases
ajcrites
force-pushed
the
no-implicit-dependencies-whitelist
branch
from
e4b6caa
to
d3cfec2
Compare
suchanlee
reviewed
Jun 28, 2018
| @@ -64,9 +76,15 @@ export class Rule extends Lint.Rules.AbstractRule { | |||
| } | |||
|
|
|||
| public apply(sourceFile: ts.SourceFile): Lint.RuleFailure[] { | |||
| let whitelist = this.ruleArguments.find((arg) => Array.isArray(arg)) as string[]; | |||
There was a problem hiding this comment.
you should be able to do:
const whitelist = this.ruleArguments.find((arg) => Array.isArray(arg)) || [];
There was a problem hiding this comment.
This gives a couple of errors:
ERROR: 79:83 strict-boolean-expressions This type is not allowed in the operand for the '||' operator because it is always truthy. Allowed types are boolean or boolean-or-undefined.
ERROR: 84:13 no-unsafe-any Unsafe use of expression of type 'any'.
| @@ -77,7 +95,7 @@ function walk(ctx: Lint.WalkContext<Options>) { | |||
| for (const name of findImports(ctx.sourceFile, ImportKind.All)) { | |||
| if (!ts.isExternalModuleNameRelative(name.text)) { | |||
| const packageName = getPackageName(name.text); | |||
| if (builtins.indexOf(packageName) === -1 && !hasDependency(packageName)) { | |||
| if (options.whitelist.indexOf(packageName) === -1 && builtins.indexOf(packageName) === -1 && !hasDependency(packageName)) { | |||
There was a problem hiding this comment.
it would be a good idea to create a Set outside of the for loop to make the check faster.
Use Set for whitelist package name comparison instead of Array.
suchanlee
approved these changes
Jun 28, 2018
|
alrighty lets merge it! |
|
do you want to close #3839 ? |
pablobirukov
pushed a commit
to evolution-gaming/tslint
that referenced
this pull request
Jul 4, 2018
…r#3839) (palantir#3979) * feature - no-implicit-dependencies - add whitelist (palantir#3839) This allows you to specify a whitelist of modules that will not be part of package.json such as project-relative aliases * feature - no-implicit-dependencies - add whitelist (palantir#3839) Use Set for whitelist package name comparison instead of Array.
|
The release of this option will be the main event of 2018 🎉 |
pablobirukov
added a commit
to evolution-gaming/tslint
that referenced
this pull request
Jul 9, 2018
mhadaily
added a commit
to mhadaily/schemastore
that referenced
this pull request
Nov 6, 2018
based on this PR, palantir/tslint#3979 whitelist is now supported.
mhadaily
added a commit
to mhadaily/schemastore
that referenced
this pull request
Nov 6, 2018
based on this PR, palantir/tslint#3979 whitelist is now supported.
mhadaily
added a commit
to mhadaily/schemastore
that referenced
this pull request
Nov 6, 2018
based on this PR, palantir/tslint#3979 whitelist is now supported.
madskristensen
pushed a commit
to SchemaStore/schemastore
that referenced
this pull request
Nov 6, 2018
based on this PR, palantir/tslint#3979 whitelist is now supported.
undeadcat
pushed a commit
to undeadcat/schemastore
that referenced
this pull request
Mar 5, 2019
based on this PR, palantir/tslint#3979 whitelist is now supported.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows you to specify a whitelist of modules that will not be part of package.json such as project-relative aliases
PR checklist
Overview of change:
This adds an option to
no-implicit-dependenciesto specify dependencies that will be known not to be included in package.json such as project-relative imports.CHANGELOG.md entry:
[new-rule-option] [no-implicit-dependencies] whitelist