This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
no-inferrable-types: Add ignore-params flag #1190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -27,13 +27,23 @@ export class Rule extends Lint.Rules.AbstractRule { | |||
| } | |||
|
|
|||
| class NoInferrableTypesWalker extends Lint.RuleWalker { | |||
| public ignoreParameters: boolean = false; | |||
There was a problem hiding this comment.
Define a const OPTION_IGNORE_PARAMS = "ignore-params"; above the class Rule declaration.
|
Looks good! Can you just make the change noted above to how you handle the option provided? This will make it more consistent with other rules |
This change allows using no-inferrable types at times when you may want to still require types for method/function parameter lists (for example when using the typedef rule)
abierbaum
force-pushed
the
inferrable-types/ignore-params
branch
from
eaedf6a
to
e3e6424
Compare
|
@jkillian I made the changes suggested and pushed up a new commit with everything fixed up. Let me know if there is anything more to change. |
|
All good, thanks @abierbaum! |
tomduncalf
pushed a commit
to tomduncalf/tslint
that referenced
this pull request
Jun 14, 2016
This change allows using no-inferrable types at times when you may want to still require types for method/function parameter lists (for example when using the typedef rule)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows using no-inferrable types at times when you
may want to still require types for method/function parameter lists
(for example when using the typedef rule)
It helps to workaround the issues in #711