Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new rule (no space before '>') #199

Closed
wants to merge 1 commit into from
Closed

Add new rule (no space before '>') #199

wants to merge 1 commit into from

Conversation

matei-oltean
Copy link

Adds a new rule to check for whitespaces before '>' (e.g. <div >)

@palantirtech
Copy link
Member

Thanks for your interest in palantir/tslint-react, @matei-oltean! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

@adidahiya
Copy link
Contributor

Sorry, I don't think it makes sense to add new formatting rules to this repo, as per palantir/tslint#4534.

FWIW, in the future, new rule implementations like this need to include test cases.

@adidahiya adidahiya closed this Mar 12, 2019
@adidahiya adidahiya added Type: Rule Suggestion Resolution: Declined Formatting rule Relates to a rule which enforces code formatting and likely overlaps with prettier labels Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Formatting rule Relates to a rule which enforces code formatting and likely overlaps with prettier Resolution: Declined Type: Rule Suggestion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants