Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Safety propagation takes into account known subtypes #2703

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Safety propagation takes into account known subtypes #2703

wants to merge 2 commits into from

Conversation

carterkozak
Copy link
Contributor

==COMMIT_MSG==
Safety propagation takes into account known subtypes
==COMMIT_MSG==

Possible downsides?

Rollout is tricky

@carterkozak carterkozak changed the base branch from ckozak/gh2668 to develop April 12, 2024 16:51
@carterkozak carterkozak force-pushed the ckozak/safety_includes_known_subtypes branch from 9a31ef5 to 7795392 Compare April 12, 2024 16:55
@carterkozak carterkozak changed the title [stacked] Safety propagation takes into account known subtypes Safety propagation takes into account known subtypes Apr 12, 2024
@carterkozak carterkozak marked this pull request as ready for review April 12, 2024 16:55
@changelog-app
Copy link

changelog-app bot commented Apr 12, 2024 •
edited by carterkozak

Generate changelog in changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Safety propagation takes into account known subtypes

Check the box to generate changelog(s)

  • Generate changelog entry

@ash211 ash211 requested a review from bjlaub April 12, 2024 17:00
bjlaub
bjlaub reviewed Apr 12, 2024
View reviewed changes
baseline-error-prone/src/main/java/com/palantir/baseline/errorprone/MoreASTHelpers.java
return false;
}
long flags = classSymbol.flags();
return (flags & (1L << 62)) != 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are there JDK docs for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjlaub bjlaub bjlaub left review comments

Assignees
No one assigned
Labels
autorelease merge when ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@carterkozak @bjlaub @svc-changelog