Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove round corner for search inputs #6779

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

CPerinet
Copy link
Contributor

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

Remove the rounded corners of search inputs.

Screenshot

@changelog-app
Copy link

changelog-app bot commented Apr 30, 2024

Generate changelog in packages/core/changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Remove round corner for search inputs

Check the box to generate changelog(s)

  • Generate changelog entry

@svc-palantir-github
Copy link

Remove round corner for search inputs

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@CPerinet
Copy link
Contributor Author

CPerinet commented Apr 30, 2024

@adidahiya

There are instances when the round corner looks off — typically when placed next to a square-er component such as Button. As a result, the default input is used in many instances instead of the type="search". Thus, we lose the semantic and esc behaviour.

I appreciate that, with this change, there is not much in the way of telling a search input from a default input. The way I see it being done is through icon="IconNames.SEARCH" and placeholder="Search...". Maybe we could set those as default for the search input?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants