Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #6734 checkbox icon opacity issue #6758

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

JamesHighsmith
Copy link

Fixes #0000

This pull request addresses an issue with the opacity of the checkbox icon in its disabled state. Previously, the opacity was set to 0.6, which did not provide enough contrast against the background, making it hard to distinguish for some users.

Changes proposed in this pull request:
Adjust the opacity of the checkbox icon in the disabled state from 0.6 to 0.5, improving visibility and design consistency.
Reviewers should focus on:
The change in _controls.scss for the checkbox icon opacity. Ensure this adjustment does not affect other components or create visual regressions in different states.
Screenshot:
No visual change significant enough to require a screenshot, but the difference can be observed in disabled checkboxes across the application where this change applies.

This minor adjustment ensures better consistency with the design language and improves the user experience by making the disabled state more distinguishable.

@palantirtech
Copy link
Member

Thanks for your interest in palantir/blueprint, @JamesHighsmith! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

@changelog-app
Copy link

changelog-app bot commented Apr 5, 2024

Generate changelog in packages/core/changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

fix #6734 checkbox icon opacity issue

Check the box to generate changelog(s)

  • Generate changelog entry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants