[core] fix(ContextMenu): create PopoverOverlay to avoid using popper.js

[adidahiya]

Fixes #5503

Checklist

• Includes tests
• Update documentation

Changes proposed in this pull request:

• Refactor Popover's overlay functionality into a new component called PopoverOverlay which must be absolutely positioned on the page via props.style
• Use PopoverOverlay in Popover, ContextMenu, and ContextMenuPopover
• This removes popper.js behavior from ContextMenu and ContextMenuPopover, since we already have all the information we need to position the menu on the page with fixed positioning
  • I was never able to fully get to the bottom of the issue here, but for some reason @popperjs/core would not position our context menu "virtual target" element correctly in React 18 strict mode. Perhaps it's violating the rules somehow. I bet their advice would be to migrate to Floating UI, which we're not going to do any time soon (see Migrate to Floating UI #5739). So I figure the best approach is to stop using popper.js -- we don't even need any of its features for our context menu implementation.
• This fixes Context menu snaps to top left corner in React 18 Strict Mode #5503, but that's only testable on a branch with React 18 used throughout the whole monorepo: [DEMO] use React 18 in demo-app, fix ContextMenu positioning #6702
• Note that there is a small breaking change to ContextMenuPopover: the rootBoundary prop is now ignored, as it doesn't make sense to have this be anything other than "viewport"

Reviewers should focus on:

No regressions in any popover-related components + context menu

Screenshot

[adidahiya]

[core] fix(ContextMenu): create PopoverOverlay to avoid using popper.js

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

[adidahiya]

fix core:test:typeCheck

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

[adidahiya]

minor code style fix: destructure transitionDuration

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

[adidahiya]

note that we no longer use ContextMenuPopover in Blueprint but it is still exported in the public API to avoid a breaking change. we should probably deprecate that component.

edit: no, actually, we can migrate ContextMenuPopover to use PopoverOverlay and continue supporting it.

[adidahiya]

previously, this cancelContextMenu functionality happened in ContextMenuPopover

[adidahiya]

fwd more props to fix bugs

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

[adidahiya]

migrate ContextMenuPopover to PopoverOverlay

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

[adidahiya]

fix resize sensor coverage

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

[adidahiya]

Confirmed that this fixes the linked bug in React 18 strict mode on this branch: #6702

you can see that demo-app is rendering in strict mode: https://github.com/palantir/blueprint/blob/ad/fix-context-menu-snapping/packages/demo-app/src/index.tsx#L33-L37

[ab-pm]

for some reason @popperjs/core would not position our context menu "virtual target" element correctly in React 18 strict mode. Perhaps it's violating the rules somehow.

Have a look at #4642 (comment) for how to get rid of the "virtual target" rendered in a portal, and use a popper.js virtual element instead.
Admittedly updating the ref from renderTarget causes a "Warning: Cannot update a component (Manager) while rendering a different component (Reference). To locate the bad setState() call inside Reference, follow the stack trace as described in https://reactjs.org/link/setstate-in-render". However if this was built into the <Popover> code (instead of my hacky attempt), it could actually update the ref from the context menu click handler.