Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default button background color to white #6578

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

CPerinet
Copy link
Contributor

@CPerinet CPerinet commented Nov 30, 2023

Before
Screenshot 2023-11-30 at 18 08 56

After
Screenshot 2023-11-30 at 18 08 52

@adidahiya
Copy link
Contributor

Update default button background color to white

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@adidahiya
Copy link
Contributor

Hmm, I'm not sure I agree with this change. The default button now looks very similar to outlined buttons:

Default Outlined
image image

When two options look very similar, it begs the question of why are these both available? And IMO it would be better if the design system was more opinionated and only allowed one of them, or kept them separate as more visually distinct options. If we do move in this direction, then I think outlined would have to be deprecated. But personally, I like the light gray background of the default button...

@CPerinet
Copy link
Contributor Author

CPerinet commented Dec 1, 2023

On a white background, default and outlined when no intent will look quite similar indeed. That said, on any other background they would look more different — we could remove the outlined but I'm unsure if that'd be worth the effort given all other intent would remain different

@nerdstep
Copy link
Contributor

nerdstep commented Dec 8, 2023

As an alternate idea, what if buttons (and maybe other components) could support a "theme color" instead of, or in addition to, the intent colors. In other words, why can't we have a violet button? :)

FWIW, we've implemented this for our project on some components:

image image

The default is still gray, but you can also use a white or black version if you want, or any of the other colors.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants