chore: [IOPID-1829] Change button on ToS screen

[Ladirico]

Short description

Change button on ToS screen (use FooterWithButtons)

E2E

Tip

List of changes proposed in this pull request

• Change button on ToS screen

iOS

Onboarding	Onboarding Error	Profile	Profile Error

Android

Onboarding	Onboarding Error	Profile	Profile Error

How to test

run the app as first onboarding
NB: to simulate error on tos screen need to change this value

[pagopa-github-bot]

Affected stories

• ⚙️ IOPID-1829: [DS-Onboarding] [APP] Integrazione bottone in schermata ToS
  subtask of
  • ⚡ IOPID-1498: DS - Schermate Onboarding/First Onboarding (16)

Generated by 🚫 dangerJS against b2da8f1

[codecov]

Codecov Report

Attention: Patch coverage is 83.33333% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 48.86%. Comparing base (4f204b4) to head (b2da8f1).
Report is 67 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5762      +/-   ##
==========================================
+ Coverage   48.42%   48.86%   +0.43%     
==========================================
  Files        1488     1605     +117     
  Lines       31617    32245     +628     
  Branches     7669     7809     +140     
==========================================
+ Hits        15311    15755     +444     
- Misses      16238    16432     +194     
+ Partials       68       58      -10     

Files	Coverage Δ
ts/components/TosWebviewErrorComponent.tsx	50.00% <ø> (ø)
ts/screens/onboarding/OnboardingTosScreen.tsx	80.00% <100.00%> (+0.93%)	⬆️
ts/screens/profile/TosScreen.tsx	83.33% <ø> (ø)
ts/components/TosWebviewComponent.tsx	42.85% <0.00%> (-11.69%)	⬇️

... and 232 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdf4a19...b2da8f1. Read the comment docs.

[shadowsheep1]

I see a lot of "blank" space on the bottom of the screen. Did we wrap the footer with buttons inside a safe area? When we use footerWithButtons we don't need the safe area bottom space handling. What do you think? Can we do a double check?

[shadowsheep1]

What about splitting the two "bugs", UI regression on OnboardingTosScreen and Email trimming, in two separate PRs? What do you think? For the latter bug (Email trimming), while addressing it I would take the time to write some test on EmailInsertScreen to be resilient on all the use cases it handles. What do you think?

[Ladirico]

I see a lot of "blank" space on the bottom of the screen. Did we wrap the footer with buttons inside a safe area? When we use footerWithButtons we don't need the safe area bottom space handling. What do you think? Can we do a double check?

What about splitting the two "bugs", UI regression on OnboardingTosScreen and Email trimming, in two separate PRs? What do you think? For the latter bug (Email trimming), while addressing it I would take the time to write some test on EmailInsertScreen to be resilient on all the use cases it handles. What do you think?

I've made both changes, and add new screenshot into the description, let me know if everything is ok!
@shadowsheep1

[shadowsheep1]

LGTM