Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [IOBP-638] Add nested scroll enabled flag on the current payment webview modal #5758

Merged
merged 7 commits into from May 15, 2024

Conversation

Hantex9
Copy link
Contributor

@Hantex9 Hantex9 commented May 9, 2024

Short description

This PR is aimed at solving a problem that persists only on some Android devices in which when entering the required OTP in the final payment step within the webview, upon tapping on the input field to enter the OTP code the keyboard would either not appear or when it did appear it was no longer clickable.

List of changes proposed in this pull request

  • Added the nestedscrollEnabled prop to the webview;

How to test

To test this fix, start the as-is payment stream on a device or emulator that is an Android 10 or 11 in UAT environment and verify that when tapping on the form present in the OTP code entry, the keyboard works correctly

@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented May 9, 2024

Affected stories

  • 🐞 IOBP-638: Problema tap tastiera sulla webview di pagamento lato Android

Generated by 🚫 dangerJS against 39d8ca6

Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.52%. Comparing base (4f204b4) to head (39d8ca6).
Report is 76 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5758      +/-   ##
==========================================
+ Coverage   48.42%   49.52%   +1.09%     
==========================================
  Files        1488     1603     +115     
  Lines       31617    31886     +269     
  Branches     7669     7697      +28     
==========================================
+ Hits        15311    15792     +481     
+ Misses      16238    16040     -198     
+ Partials       68       54      -14     
Files Coverage Δ
ts/components/wallet/PayWebViewModal.tsx 63.63% <ø> (-2.28%) ⬇️

... and 420 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2349078...39d8ca6. Read the comment docs.

@Hantex9 Hantex9 merged commit f0d2477 into master May 15, 2024
13 checks passed
@Hantex9 Hantex9 deleted the IOBP-638-fix-android-webview-keyboard-tap branch May 15, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🐞 IO-Bonus e pagamenti IO - Bonus e pagamenti
Development

Successfully merging this pull request may close these issues.

None yet

3 participants