New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IOCOM-1370, IOCOM-1371] Selectable service name in message details (both standard and SEND), new DS #5757
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5757 +/- ##
==========================================
+ Coverage 48.42% 49.54% +1.12%
==========================================
Files 1488 1604 +116
Lines 31617 31879 +262
Branches 7669 7656 -13
==========================================
+ Hits 15311 15795 +484
+ Misses 16238 16030 -208
+ Partials 68 54 -14
... and 436 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Short description
This PR makes the service name selectable on the message details' screen, with the new DS on both standard and SEND messages (selection leads to service details' screen).
List of changes proposed in this pull request
OrganizationHeader
implements theonPress
event on the service name, leading to the service details' screenMessageDetailsHeader
adds theserviceId
parameter toOrganizationHeader
componentHow to test
Using the io-dev-api-server, check that both standard and SEND messages have a selectable service name that leads to the service details' screen