Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IOCOM-1370, IOCOM-1371] Selectable service name in message details (both standard and SEND), new DS #5757

Merged
merged 14 commits into from May 17, 2024

Conversation

Vangaorth
Copy link
Contributor

Short description

This PR makes the service name selectable on the message details' screen, with the new DS on both standard and SEND messages (selection leads to service details' screen).

Standard message SEND message
Simulator Screenshot - iPhone 15 - 2024-05-09 at 15 26 25 Simulator Screenshot - iPhone 15 - 2024-05-09 at 15 26 34

List of changes proposed in this pull request

  • OrganizationHeader implements the onPress event on the service name, leading to the service details' screen
  • MessageDetailsHeader adds the serviceId parameter to OrganizationHeader component

How to test

Using the io-dev-api-server, check that both standard and SEND messages have a selectable service name that leads to the service details' screen

@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented May 9, 2024

Warnings
⚠️ Please include a Jira ticket at the beginning of the PR title

Example of PR titles that include Jira tickets:

  • single story: [PROJID-123] my PR title
  • multiple stories: [PROJID-1,PROJID-2,PROJID-3] my PR title

Generated by 🚫 dangerJS against 5d15842

Copy link

codecov bot commented May 9, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 49.54%. Comparing base (4f204b4) to head (5d15842).
Report is 82 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5757      +/-   ##
==========================================
+ Coverage   48.42%   49.54%   +1.12%     
==========================================
  Files        1488     1604     +116     
  Lines       31617    31879     +262     
  Branches     7669     7656      -13     
==========================================
+ Hits        15311    15795     +484     
+ Misses      16238    16030     -208     
+ Partials       68       54      -14     
Files Coverage Δ
.../components/MessageDetail/MessageDetailsHeader.tsx 100.00% <ø> (ø)
...es/components/MessageDetail/OrganizationHeader.tsx 88.88% <80.00%> (-11.12%) ⬇️

... and 436 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55fa198...5d15842. Read the comment docs.

Copy link
Contributor

@forrest57 forrest57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Vangaorth Vangaorth merged commit e8eeee1 into master May 17, 2024
13 checks passed
@Vangaorth Vangaorth deleted the IOCOM-1370-serviceLinkClick branch May 17, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants