Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [IOPLT-305] Add Sentry Tool for Crash reporting #5756

Draft
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

CrisTofani
Copy link
Contributor

Short description

This PR adds the Sentry SDK to track and handle crash informations.

List of changes proposed in this pull request

  • Feature A
  • Feature B

How to test

Describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

@pagopa-github-bot pagopa-github-bot changed the title [IOPLT-305] Add Sentry Tool for Crash reporting feat: [IOPLT-305] Add Sentry Tool for Crash reporting May 9, 2024
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented May 9, 2024

Affected stories

  • 🌟 IOPLT-305: Come DEV dell'APP IO voglio usufruire dei servizi di Sentry al fine di poter inviare eventi utili alla redazione di crash reporting
    subtask of

Generated by 🚫 dangerJS against 8861571

Copy link

codecov bot commented May 9, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 49.57%. Comparing base (4f204b4) to head (8861571).
Report is 97 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5756      +/-   ##
==========================================
+ Coverage   48.42%   49.57%   +1.14%     
==========================================
  Files        1488     1623     +135     
  Lines       31617    32186     +569     
  Branches     7669     7734      +65     
==========================================
+ Hits        15311    15955     +644     
+ Misses      16238    16177      -61     
+ Partials       68       54      -14     
Files Coverage Δ
ts/config.ts 100.00% <100.00%> (ø)
ts/screens/profile/DeveloperModeSection.tsx 4.31% <0.00%> (-0.17%) ⬇️

... and 537 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bfb1d2...8861571. Read the comment docs.

ts/App.tsx Outdated
import { sentryDsn } from "./config";
import { isLocalEnv } from "./utils/environment";

const removeUserFromEvent = (event: any) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const removeUserFromEvent = (event: any) => {
const removeUserFromEvent = (event: unknown) => {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed in 90a64a5 with correct types

ts/App.tsx Outdated Show resolved Hide resolved
Co-authored-by: Fabio Bombardi <16268789+shadowsheep1@users.noreply.github.com>
ios/ItaliaApp/PrivacyInfo.xcprivacy Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
legal-review-needed ⚖️ ⛔ this PR is under legal check.
Development

Successfully merging this pull request may close these issues.

None yet

5 participants