Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [PE-587,PE-589,PE-591] CGN revamp fixes #5754

Merged
merged 11 commits into from May 15, 2024
Merged

Conversation

Hantex9
Copy link
Contributor

@Hantex9 Hantex9 commented May 9, 2024

Short description

This PR fixes:

  • Dividers between merchant categories;
  • Wrong scrollbar into merchant details screen;
  • Wrong badge spacing into list item nav;

List of changes proposed in this pull request

  • Added <Divider /> component between categories list items;
  • Removed the default chevron from the ListItemNav adding a custom one with custom spacing

How to test

Inside the CGN flows, open the categories list and merchant details

@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented May 9, 2024

Warnings
⚠️

Multiple stories with different types are associated with this Pull request.
Only one tag will be added, following the order: feature > bug > chore

Affected stories

  • 🐞 PE-587: Divider mancante tra le categorie
    subtask of
    • PE-511: CGN - Adeguamento flussi/schermate a nuovo DS 2.0
  • 🐞 PE-589: [iOS] La scrollbar verticale viene mostrata al centro dello schermo
    subtask of
    • PE-511: CGN - Adeguamento flussi/schermate a nuovo DS 2.0
  • 🐞 PE-591: Posizionamento errato dei badge nei list item
    subtask of
    • PE-511: CGN - Adeguamento flussi/schermate a nuovo DS 2.0

Generated by 🚫 dangerJS against e10cc6a

Copy link

codecov bot commented May 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 49.58%. Comparing base (4f204b4) to head (e10cc6a).
Report is 73 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5754      +/-   ##
==========================================
+ Coverage   48.42%   49.58%   +1.16%     
==========================================
  Files        1488     1597     +109     
  Lines       31617    31810     +193     
  Branches     7669     7686      +17     
==========================================
+ Hits        15311    15774     +463     
+ Misses      16238    15982     -256     
+ Partials       68       54      -14     
Files Coverage Δ
.../cgn/screens/merchants/CgnMerchantDetailScreen.tsx 12.12% <ø> (-0.70%) ⬇️
...eens/merchants/CgnMerchantCategoriesListScreen.tsx 2.63% <0.00%> (ø)
.../cgn/components/merchants/CgnMerchantsListView.tsx 12.50% <0.00%> (ø)

... and 412 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac022ab...e10cc6a. Read the comment docs.

@Hantex9 Hantex9 merged commit e0dcee1 into master May 15, 2024
13 checks passed
@Hantex9 Hantex9 deleted the PE-587-589-fixes-CGN branch May 15, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants