Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(IT Wallet): [SIW-980] Add eID issuing IDP selection screen #5752

Merged

Conversation

mastro993
Copy link
Contributor

@mastro993 mastro993 commented May 8, 2024

Short description

This PR introduces the IDP selection screen for the eID issuing

List of changes proposed in this pull request

  • Added ItwIdentificationIdpSelectionScreen component
  • Added related route and paramters

How to test

Navigate to Profile -> IT Wallet -> Issuing -> SPID

Preview

RocketSim_Recording_iPhone_14_6.1_2024-05-15_17.45.57.mp4

@mastro993 mastro993 requested a review from a team as a code owner May 8, 2024 16:12
@pagopa-github-bot pagopa-github-bot changed the title [SIW-980] Add eID issuing IDP selection screen feat(IT Wallet): [SIW-980] Add eID issuing IDP selection screen May 8, 2024
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented May 8, 2024

Affected stories

  • 🌟 SIW-980: Come cittadino voglio visualizzare l'elenco di SPID provider se scelgo SPID come metodo di autenticazione
    subtask of

Generated by 🚫 dangerJS against d530c8a

Copy link

codecov bot commented May 10, 2024

Codecov Report

Attention: Patch coverage is 8.33333% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 49.53%. Comparing base (4f204b4) to head (35645d6).
Report is 80 commits behind head on master.

❗ Current head 35645d6 differs from pull request most recent head d530c8a. Consider uploading reports for the commit d530c8a to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5752      +/-   ##
==========================================
+ Coverage   48.42%   49.53%   +1.10%     
==========================================
  Files        1488     1605     +117     
  Lines       31617    31880     +263     
  Branches     7669     7770     +101     
==========================================
+ Hits        15311    15791     +480     
+ Misses      16238    16026     -212     
+ Partials       68       63       -5     
Files Coverage Δ
...features/itwallet/navigation/ItwStackNavigator.tsx 66.66% <ø> (ø)
ts/features/itwallet/navigation/routes.ts 100.00% <ø> (ø)
...n/screens/ItwIdentificationModeSelectionScreen.tsx 4.34% <0.00%> (ø)
...on/screens/ItwIdentificationIdpSelectionScreen.tsx 9.09% <9.09%> (ø)

... and 420 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8760edc...d530c8a. Read the comment docs.

Copy link
Contributor

@LazyAfternoons LazyAfternoons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mastro993 mastro993 merged commit d5d5681 into master May 16, 2024
11 checks passed
@mastro993 mastro993 deleted the SIW-980-add-identification-spid-provider-list-screen branch May 16, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants