Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [IOPID-1548] DS add new cie errors #5750

Merged
merged 40 commits into from May 22, 2024
Merged

Conversation

Ladirico
Copy link
Contributor

@Ladirico Ladirico commented May 8, 2024

Short description

Add CIE errors screens. Change generic error design and add errors 22 and 1001.

List of changes proposed in this pull request

  • Fix the incorrect visualization of error 1002 (using a custom WizardScreen -> create component CustomWizardScreen)
  • Add tests
  • Add screens for error 1001 and 22 and generic
  • Add new route to visualize CIE error
  • Change CieConsentDataUsageScreen from class component to function component
  • Change folder of UnlockAccessScreen from onboarding to authentication

Tip

Run e2e tests

Note

  1. To test all error cases, I used Proxyman by forcing the response that should come from the BE. So the flow is not correct, in fact error 1002 is not displayed with the L3 access type
  2. The A11Y test were not realised because the same components were tested in many other PR
  3. I modified the component for error 1002, which is in common with SPID, so I additionally tested the spid flow for error 1002.

iOS screens

Error 1001 Error 1002 Error 22 Error Generic SPID Error 1002
IOS_CIE_1001.mov
IOS_CIE_1002.MOV
IOS_CIE_22.MOV
IOS_CIE_GEN.MOV
IOS_SPID_1002.MOV

Android screens

Error 1001 Error 1002 Error 22 Error Generic SPID Error 1002
android_cie_1001.mp4
android_cie_1002.mp4
android_cie_22.mp4
android_cie_gen.mp4
android_spid_1002.mp4

How to test

IOS: before building the app run yarn cie-ios:prod and then perform authentication flow with CIE
Android: run the application using .env.production

@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented May 8, 2024

Affected stories

Generated by 🚫 dangerJS against b293956

@Ladirico Ladirico changed the title add new generic component [IOPID-1548] DS add new cie errors May 8, 2024
Copy link

codecov bot commented May 8, 2024

Codecov Report

Attention: Patch coverage is 34.65347% with 66 lines in your changes are missing coverage. Please review.

Project coverage is 49.56%. Comparing base (4f204b4) to head (b293956).
Report is 94 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5750      +/-   ##
==========================================
+ Coverage   48.42%   49.56%   +1.14%     
==========================================
  Files        1488     1623     +135     
  Lines       31617    32181     +564     
  Branches     7669     7734      +65     
==========================================
+ Hits        15311    15952     +641     
+ Misses      16238    16175      -63     
+ Partials       68       54      -14     
Files Coverage Δ
ts/navigation/AuthenticationNavigator.tsx 40.00% <ø> (ø)
ts/navigation/routes.ts 100.00% <ø> (ø)
...s/screens/authentication/UnlockAccessComponent.tsx 94.44% <100.00%> (ø)
ts/screens/authentication/UnlockAccessScreen.tsx 100.00% <100.00%> (ø)
ts/screens/authentication/IdpLoginScreen.tsx 4.04% <0.00%> (+0.04%) ⬆️
.../authentication/cie/components/AuthErrorScreen.tsx 83.33% <83.33%> (ø)
ts/components/screens/CustomWizardScreen.tsx 85.71% <85.71%> (ø)
.../screens/authentication/cie/CieAuthErrorScreen.tsx 11.11% <11.11%> (ø)
...s/authentication/cie/CieConsentDataUsageScreen.tsx 3.33% <3.57%> (-3.81%) ⬇️

... and 529 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09693da...b293956. Read the comment docs.

@pagopa-github-bot pagopa-github-bot changed the title [IOPID-1548] DS add new cie errors feat: [IOPID-1548] DS add new cie errors May 10, 2024
@Ladirico Ladirico self-assigned this May 10, 2024
@Ladirico Ladirico added the IO-A&I IO - Autenticazione e Identità label May 10, 2024
Copy link
Member

@shadowsheep1 shadowsheep1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ladirico Ladirico merged commit 26916b7 into master May 22, 2024
13 checks passed
@Ladirico Ladirico deleted the IOPID-1548-ds-cie-errors branch May 22, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO-A&I IO - Autenticazione e Identità
Development

Successfully merging this pull request may close these issues.

None yet

5 participants