New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [IOPID-1548] DS add new cie errors #5750
Conversation
Affected stories
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5750 +/- ##
==========================================
+ Coverage 48.42% 49.56% +1.14%
==========================================
Files 1488 1623 +135
Lines 31617 32181 +564
Branches 7669 7734 +65
==========================================
+ Hits 15311 15952 +641
+ Misses 16238 16175 -63
+ Partials 68 54 -14
... and 529 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
…rom class component in function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Short description
Add CIE errors screens. Change generic error design and add errors 22 and 1001.
List of changes proposed in this pull request
CieConsentDataUsageScreen
from class component to function componentTip
Note
iOS screens
IOS_CIE_1001.mov
IOS_CIE_1002.MOV
IOS_CIE_22.MOV
IOS_CIE_GEN.MOV
IOS_SPID_1002.MOV
Android screens
android_cie_1001.mp4
android_cie_1002.mp4
android_cie_22.mp4
android_cie_gen.mp4
android_spid_1002.mp4
How to test
IOS: before building the app run
yarn cie-ios:prod
and then perform authentication flow with CIEAndroid: run the application using .env.production