chore: [IOCOM-1354] NOTIFICATION_PERMISSION super and profile property
#5749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # package.json # yarn.lock
# Conflicts: # package.json # yarn.lock
# Conflicts: # package.json # yarn.lock
# Conflicts: # ts/features/pushNotifications/hooks/usePreviewMoreInfo.tsx # ts/features/pushNotifications/screens/OnboardingNotificationsInfoScreenConsent.tsx # ts/features/pushNotifications/screens/OnboardingNotificationsPreferencesScreen.tsx # ts/screens/profile/NotificationsPreferencesScreen.tsx
# Conflicts: # package.json # ts/features/pushNotifications/hooks/usePreviewMoreInfo.tsx # ts/features/pushNotifications/screens/OnboardingNotificationsInfoScreenConsent.tsx # ts/features/pushNotifications/screens/OnboardingNotificationsPreferencesScreen.tsx # ts/screens/profile/NotificationsPreferencesScreen.tsx # yarn.lock
# Conflicts: # ts/features/pushNotifications/components/__tests__/NotificationPreviewSample.test.tsx # ts/features/pushNotifications/hooks/usePreviewMoreInfo.tsx # ts/features/pushNotifications/sagas/checkNotificationsPermissionsSaga.ts # ts/features/pushNotifications/sagas/checkNotificationsPreferencesSaga.ts # ts/features/pushNotifications/screens/OnboardingNotificationsInfoScreenConsent.tsx # ts/features/pushNotifications/screens/OnboardingNotificationsPreferencesScreen.tsx # ts/features/pushNotifications/screens/__tests__/OnboardingNotificationsInfoScreenConsent.test.tsx # ts/features/pushNotifications/screens/__tests__/OnboardingNotificationsPreferencesScreen.test.tsx # ts/features/pushNotifications/utils/configurePushNotification.ts # ts/sagas/startup/__tests__/checkNotificationsPermissionsSaga.test.tsx # ts/screens/profile/NotificationsPreferencesScreen.tsx
|
🎉 All dependencies have been resolved ! |
# Conflicts: # ts/features/pushNotifications/sagas/__tests__/checkNotificationsPreferencesSaga.test.tsx # ts/features/pushNotifications/sagas/checkNotificationsPreferencesSaga.ts # ts/features/pushNotifications/screens/OnboardingNotificationsInfoScreenConsent.tsx # ts/screens/profile/NotificationsPreferencesScreen.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR adds the
NOTIFICATION_PERMISSION: "enabled"/"disabled"property to both super and profile properties.It also refactors the
checkNotificationsPreferencesSagato be more readable.List of changes proposed in this pull request
ts/screens/profile/analytics/index.ts: type and utility to convert from boolean to typets/mixpanelConfig/profileProperties.tsandts/mixpanelConfig/superProperties.ts: property added with related code to compute its valuets/features/pushNotifications/sagas/checkNotificationsPreferencesSaga.ts: code flow refactored to be more readable (with full tests)ts/features/pushNotifications/screen/OnboardingNotificationsInfoScreenConsent.ts: modal dismissal moved to the saga aboveHow to test
Using the io-dev-api-server, check that: