feat: [IOPID-1507] Integrate new DS in Pin Screen flow #5737
+956
−561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rding-app-pin-screen
pagopa-github-bot
changed the title
Affected stories
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5737 +/- ##
==========================================
+ Coverage 48.42% 49.80% +1.38%
==========================================
Files 1488 1629 +141
Lines 31617 32268 +651
Branches 7669 7728 +59
==========================================
+ Hits 15311 16072 +761
+ Misses 16238 16142 -96
+ Partials 68 54 -14
... and 550 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
@mariateresaventura copy review needed 🙏🏼 |
…rding-app-pin-screen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Split Pin Screen in two dedicated components
List of changes proposed in this pull request
PinCreationandPinConfirmationcomponents which respectively handle the pin creation and confirmation workflowsProfilesection with a non-blocking toast message**CodeInputcomponent with a custom wrapper delegated to trigger keyboard opening on element focusNote
** The need to restart the application after the pin was changed comes from this PR to make it immediately available in app. Today this behavior is not necessary anymore because the pin is now retrieved directly from
react-native-keychainwhen needed.Test
E2E
Tip
Screens
iOS
iOS-onboarding-pin-creation.mp4
iOS-change-pin-success.mp4
iOS-pin-validation-error.mp4
iOS-pin-confirmation-error.mp4
Android
Android-onboarding-pin-creation.mp4
Android-change-ping-success.mp4
Android-pin-validation-error.mp4
Android-pin-confirmation-error.mp4
Accessibility iOS & Android
a11y-.MP4
a11y-.mp4
How to test
Since this component is used in two sections of the app -
OnboardingandProfileflows - there are two different ways in which it can be tested.Profile section
This is the easiest way in which it can be tested:
Profile > Security > Change the unlock codeOnboarding section
Testing in local environment - clone io-dev-api-server repo if you haven't did it yet and follow the instructions - go in
config/config.jsonand inprofile.attrsadd a fiscal code underfiscal_codekey (must be 16 characters long), restart you backend and then restart the application to login again and display the onboarding flow with the new Pin Screen.{ "profile": { "attrs": { "name": "Gian Maria", "fiscal_code": "AAAAAA00A00A000B" } } }Tip
To try multiple times repeat the process changing at least one
fiscal_codecharacter